chore: bring in github.com/orijtech/chdbg tool #14643
Conversation
github-prbot
requested review from
a team,
amaury1093 and
facundomedica
and removed request for
a team
|
CC @odeke-em |
Signed-off-by: Elias Naur <elias@orijtech.com>
elias-orijtech
force-pushed
the
tools-chdbg
branch
from
b3af0c7 to
30d03c5
Compare
elias-orijtech
changed the title
elias-orijtech
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| it1.Close() | ||
| it2.Close() |
Check warning
Code scanning / gosec
Errors unhandled.
| break loop | ||
| } | ||
| } | ||
| it1.Close() |
Check warning
Code scanning / gosec
Errors unhandled.
There was a problem hiding this comment.
utACK. This still needs to be done: https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#gomod and possibly configuring the docs. We can do that in a follow-up if you prefer.
|
|
||
| require ( | ||
| github.com/cosmos/cosmos-db v0.0.0-20221127110041-4564dc28e22b | ||
| github.com/cosmos/iavl v0.19.2-0.20221208111139-992120de42e1 |
| @@ -0,0 +1,28 @@ | |||
| # chdbg | |||
There was a problem hiding this comment.
we should add some more information here on how to use it and read it. the below excerpt isn't very intuivutve since its hard to tell which store is the issue.
In the sdk we have a convention of providing a cli with helper text, should we adopt that here @julienrbrt ?
There was a problem hiding this comment.
Maybe all tools should use cobra yes.
| } | ||
| } | ||
|
|
||
| func diff(dbdir1, dbdir2 string) error { |
There was a problem hiding this comment.
could we add some godocs to this file?
|
Let us know if you need a hand pushing this over the finish line 👌 |
|
In light of #13404 (comment) and orijtech/chdbg#1 (comment) I'm skeptical of pushing this PR through. Maybe just transfer the chdbg repository to Cosmos for now? Or, leave it as is until chdbg proves valuable for actual debugging use-cases. Also, according to Finally, I don't have the intimate knowledge of Cosmos to reproduce useful and typical debugging scenarios. For example, the notes at #13404 (comment) are helpful, but not enough for me. I suggest setting up a meeting with someone from Cosmos that can provide me with the necessary details for reproducing chain halts and what information would be useful. |
|
closing this PR as mentioned in the previous comment. We will keep the issue open and reassign it to someone on the team when there is time. |
No description provided.