-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: x/feegrant
to stand alone
#14649
Conversation
[Cosmos SDK - x/feegrant] Kudos, SonarCloud Quality Gate passed! |
x/feegrant/go.mod
Outdated
cosmossdk.io/depinject v1.0.0-alpha.3 | ||
cosmossdk.io/math v1.0.0-beta.4 | ||
github.com/cosmos/cosmos-proto v1.0.0-beta.1 | ||
github.com/cosmos/cosmos-sdk v0.46.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use v0.47 instead of v0.46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.47 is not releasted yet right? rc1
works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, why not leaving the v0.46.0-beta2.0.2023_____
tags? These are pseudo version of main. I don't think we can use 0.46 or 0.47 due to the store refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing changelog file in feegrant and small nits, otherwise lgtm
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@kocubinski can you do another review, of lift your block? |
…k into ap/stand-alone-feegrant
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Description
Closes: #14559
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change