-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new command to list supported algos #14655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
@@ -167,7 +177,7 @@ | |||
args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID) | |||
args.minGasPrices, _ = cmd.Flags().GetString(server.FlagMinGasPrices) | |||
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
@@ -134,7 +144,7 @@ | |||
args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome) | |||
args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress) | |||
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
@@ -113,7 +123,7 @@ | |||
outputFormat := ctx.OutputFormat | |||
|
|||
keyringAlgos, _ := kb.SupportedAlgorithms() | |||
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for") | ||
|
||
// support old flags name for backwards compatibility | ||
cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd.PersistentFlags()
should have been cmd.Flags()
and my fat fingers merged from my phone.
I can fix in on some unrelated incoming PR.
f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for") | ||
|
||
// support old flags name for backwards compatibility | ||
cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd.PersistentFlags()
should have been cmd.Flags()
and my fat fingers merged from my phone.
I can fix in on unrelated incoming PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
(cherry picked from commit 5233d5e) # Conflicts: # CHANGELOG.md # simapp/simd/cmd/testnet.go
Description
Closes: #8886
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change