Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): indexes for IndexedMap #14706

Merged
merged 55 commits into from
Feb 3, 2023
Merged

feat(collections): indexes for IndexedMap #14706

merged 55 commits into from
Feb 3, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Jan 19, 2023 •
edited
Loading

Description

depends on: #14397

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

testinginprod and others added 30 commits December 15, 2022 00:06
add: init pair
4619c3c
Merge branch 'main' into tip/collections-pairkeys
39e3d8f
add: refactor ranging
f9f6773
remove useless test
28bd97e
add: testing + proper pair impl
a1861f9
Merge branch 'main' into tip/collections-pairkeys
d75e33c
Merge branch 'main' into tip/collections-pairkeys
e683ac0
add: tmp
5044359
add: pair key accessor
8ec3d87
Merge branch 'tip/collections-pairkeys' into tip/indexed_map
11ee08b
add: MultiIndex tests
dd6d29b
add: unique index tests
f43b832
change: unique index propagates pk
8ebdfd7
change: propagate primary key in indexes multi
036a7ee
Merge branch 'main' into tip/collections-pairkeys
6060a4a
chore: merge
638c582
Merge branch 'tip/collections-pairkeys' into tip/indexed_map
f3772f0 
# Conflicts:
#	collections/collections_test.go
chore: merge
6b71609
add: has method
61d5a00
Merge branch 'main' into tip/indexed_map
fc1db55 
# Conflicts:
#	collections/collections.go
#	collections/collections_test.go
#	collections/iter.go
#	collections/keys.go
#	collections/pair.go
#	collections/pair_test.go
merge main
96b7c88
@testinginprod
Merge branch 'main' into tip/indexed_map
b1ddef0
chore: merge main
f20ce08
chore: merge main2
50acaa9
change: make indexes generic
399a6b4
change indexed map test to depend on generic unique index
7d3f205
change move unique index to a separate pkg
71e2242
add: generic multi index testing
1507e38
chore: improve coverage
0489736
chore: add indexes unique testing
b404df7
testinginprod and others added 9 commits January 24, 2023 13:39
Merge branch 'main' into tip/indexed_map
d98c580 
# Conflicts:
#	collections/collections_test.go
#	collections/iter.go
#	collections/map.go
#	go.mod
#	go.sum
#	simapp/go.sum
#	tests/go.mod
#	tests/go.sum
#	x/nft/go.sum
Merge branch 'tip/indexed_map' into tip/indexed_map_indexes
ea601c6
@tac0turtle
Merge branch 'main' into tip/indexed_map
360727e
Merge branch 'main' into tip/indexed_map
207c4be 
# Conflicts:
#	collections/collections_test.go
chore: cleanups
e7088c3
@testinginprod @likhita-809
docs collections/indexes_generic_multi.go
7e34f77 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@testinginprod @likhita-809
Update collections/indexed_map.go
838295e 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
chore: docs
c7fc993
Merge branch 'tip/indexed_map' into tip/indexed_map_indexes
2292420
Base automatically changed from tip/indexed_map to main January 27, 2023 12:49
@testinginprod testinginprod marked this pull request as ready for review January 27, 2023 12:55
@testinginprod testinginprod requested a review from a team as a code owner January 27, 2023 12:55
tac0turtle
tac0turtle approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving this to move things forward. I think this is a good place to land to seek user feedback on collections.

@testinginprod testinginprod enabled auto-merge (squash) February 3, 2023 09:21
@testinginprod testinginprod merged commit bdf4c76 into main Feb 3, 2023
@testinginprod testinginprod deleted the tip/indexed_map_indexes branch February 3, 2023 09:23
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@testinginprod @tac0turtle
@likhita-809 @tsenart
feat(collections): indexes for IndexedMap (cosmos#14706)
ccc7cde 
Co-authored-by: testinginprod <testinginprod@somewhere.idk>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@JeancarloBarrios JeancarloBarrios

@likhita-809 likhita-809

Labels
C:collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testinginprod @alexanderbez @tac0turtle @JeancarloBarrios @likhita-809