fix: sdk.Coins.Add #14715
Merged
fix: sdk.Coins.Add #14715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
facundomedica and
likhita-809
and removed request for
a team
|
Could you add a changelog and fix the remaining tests? |
alexanderbez
approved these changes
Jan 20, 2023
julienrbrt
added
the
backport/v0.47.x
julienrbrt
approved these changes
Jan 20, 2023
likhita-809
reviewed
Jan 23, 2023
likhita-809
approved these changes
Jan 24, 2023
robert-zaremba
added
the
A:automerge
julienrbrt
removed
the
A:automerge
|
@robert-zaremba could you still add a changelog? |
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 32bb7f6) # Conflicts: # CHANGELOG.md
|
I was just about to add that changelog. Thanks @julienrbrt |
julienrbrt
added a commit
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sdk.Coins.Add, today the function returnsnil, if the result will end up with an empty set of coins. I've added few test to confirm that and a fix.Emptyset != nil.nilis a bad practice, because using that object will lead to panics.sdk.Coins.Subto confirm that everything works. well.Technically the PR is API changing , because we change the return value for given parameters. However, I think it goes into the bug fixes so we should backport it to 0.47 and 0.46. So tentatively adding the backport labels.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change