feat(gov,cli): Create AddGovPropFlagsToCmd and ReadGovPropFlags. #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gSummary. Make FlagMetadata public. Undeprecate FlagTitle. Add unit tests on the new funcs.
github-prbot
requested review from
a team,
alexanderbez and
julienrbrt
and removed request for
a team
19 tasks
julienrbrt
reviewed
Jan 20, 2023
| @@ -613,7 +613,7 @@ func (s *CLITestSuite) msgSubmitLegacyProposal(clientCtx client.Context, from, t | |||
| } | |||
|
|
|||
| args := append([]string{ | |||
| fmt.Sprintf("--%s=%s", govcli.FlagTitle, title), //nolint:staticcheck // SA1019: govcli.FlagTitle is deprecated: use FlagTitle instead | |||
| fmt.Sprintf("--%s=%s", govcli.FlagTitle, title), | |||
| fmt.Sprintf("--%s=%s", govcli.FlagDescription, description), //nolint:staticcheck // SA1019: govcli.FlagDescription is deprecated: use FlagDescription instead | |||
There was a problem hiding this comment.
slightly unrelated but these comments are weird, there is nothing to use instead.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cmd.Flags().String(cli.FlagDescription, "", "description of proposal") //nolint:staticcheck // we are intentionally using a deprecated flag here. | ||
| cmd.Flags().String(cli.FlagDeposit, "", "deposit of proposal") | ||
| cmd.MarkFlagRequired(cli.FlagTitle) //nolint:staticcheck // we are intentionally using a deprecated flag here. | ||
| cmd.MarkFlagRequired(cli.FlagTitle) |
Check warning
Code scanning / gosec
Errors unhandled.
|
Upgrade notes should be updated. |
I was looking around for a place in the documentation discussing how to design/implement gov v1 proposal messages/endpoints/cli/etc. but couldn't find anything. I will add this to |
As this getting in a point release, I can ping you when we backport this 👍🏾 |
|
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
) (cherry picked from commit 6674402) # Conflicts: # CHANGELOG.md # x/feegrant/client/cli/tx_test.go # x/upgrade/client/cli/parse_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14700
This PR:
FlagTitlevariable.FlagMetadatavariable public.FlagSummaryvariable.AddGovPropFlagsToCmdfunc that addsFlagDeposit,FlagMetadata,FlagTitle, andFlagSummaryto a cobra command.ReadGovPropFlagsfunc that creates aMsgSubmitProposalpre-populated with provided flag values and proposer (from address).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change