-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(orm)!: support core genesis #14822
Conversation
orm/model/ormdb/module.go
Outdated
// func NewKeeper(db ModuleDB) *Keeper { | ||
// return &Keeper{HasGenesis: db.AppModuleGenesis()} | ||
// } | ||
AppModuleGenesis() appmodule.HasGenesis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe simply:
AppModuleGenesis() appmodule.HasGenesis | |
Genesis() appmodule.HasGenesis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to GenesisHandler
. That feels a bit better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we might need a changelog entry
Added a CHANGELOG.md. Going to enable auto-merge unless anyone has any objections |
Description
This refactors the ORM's JSON code to support the core API genesis. Module's using the ORM would just need to embed to do something like this:
This also fixes a broken test introduced in #14796. Maybe something is broken in CI??
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change