feat!: return errors in module manager ABCI methods #14847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var err error | ||
| res, err = app.beginBlocker(app.deliverState.ctx, req) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| var err error | ||
| res, err = app.endBlocker(app.deliverState.ctx, req) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| @@ -656,7 +669,7 @@ | |||
| // only one module will update the validator set | |||
| if len(moduleValUpdates) > 0 { | |||
| if len(validatorUpdates) > 0 { | |||
| panic("validator EndBlock updates already set by a previous module") | |||
| return abci.ResponseEndBlock{}, errors.New("validator EndBlock updates already set by a previous module") | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
facundomedica
changed the title
|
Not sure how helpful this is given that it's moving the panics to baseapp |
github-prbot
requested review from
a team,
aaronc and
julienrbrt
and removed request for
a team
tac0turtle
approved these changes
Jan 31, 2023
| @@ -559,12 +560,12 @@ func (app *SimApp) setPostHandler() { | |||
| func (app *SimApp) Name() string { return app.BaseApp.Name() } | |||
|
|
|||
| // BeginBlocker application updates every begin block | |||
| func (app *SimApp) BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock) abci.ResponseBeginBlock { | |||
| func (app *SimApp) BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock) (abci.ResponseBeginBlock, error) { | |||
There was a problem hiding this comment.
need a changelog and upgrade entry for this
alexanderbez
approved these changes
Jan 31, 2023
…/refactor-modulemanager-methods
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14836
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change