Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rapidproto generator #14849

Merged
merged 3 commits into from
Jan 31, 2023
Merged

feat: add rapidproto generator #14849

merged 3 commits into from
Jan 31, 2023

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Jan 30, 2023

Description

Closes: #14704

This generator is being used here for work on #10993. Sourced from work in cosmos/cosmos-proto#83


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner January 30, 2023 20:57
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
testutil/rapidproto/rapidproto.go Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question, utACK

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 31, 2023
@tac0turtle tac0turtle enabled auto-merge (squash) January 31, 2023 21:06
@tac0turtle tac0turtle merged commit 72db75b into main Jan 31, 2023
@tac0turtle tac0turtle deleted the kocubinski/rapidproto branch January 31, 2023 21:26
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rapid proto message generator
5 participants