feat: add query `groups` in `x/group` #14879

atheeshp · 2023-02-02T04:26:03Z

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…p/query-groups

tac0turtle

utACK

proto/cosmos/group/v1/query.proto

likhita-809

few nits, otherwise lgtm
and also could you fix the failing tests ?

proto/cosmos/group/v1/query.proto

x/group/client/cli/query.go

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

julienrbrt

lgtm!

julienrbrt · 2023-02-02T17:43:54Z

The tests are failing and/or flaky: https://github.com/cosmos/cosmos-sdk/actions/runs/4076789586/jobs/7024995069

…p/query-groups

atheeshp · 2023-02-03T09:23:29Z

The tests are failing and/or flaky: https://github.com/cosmos/cosmos-sdk/actions/runs/4076789586/jobs/7024995069

no, there is mistake in the pagination flags, I didn't add them and while requesting I added a comma to separate the flags which omitted the second flag.

robert-zaremba · 2023-02-03T10:44:18Z

Thanks for doing this!
Can we backport it to 0.46?

julienrbrt · 2023-02-03T11:04:47Z

Thanks for doing this! Can we backport it to 0.46?

If we think about feature parity, I think we should wait to have it included on v0.47.1 / v0.47.0 released before backporting it to v0.46.
Otherwise, we may release the point version of v0.46.x with the query before v0.47.0 (hopefully not lol), which won't have it.

julienrbrt · 2023-03-20T16:03:43Z

@Mergifyio backport release/v0.47.x

mergify · 2023-03-20T16:03:48Z

backport release/v0.47.x

✅ Backports have been created

#15475 feat: add query groups in x/group (backport #14879) has been created for branch release/v0.47.x

julienrbrt · 2023-03-20T16:03:49Z

@Mergifyio backport release/v0.46.x

mergify · 2023-03-20T16:03:54Z

backport release/v0.46.x

✅ Backports have been created

#15476 feat: add query groups in x/group (backport #14879) has been created for branch release/v0.46.x

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com> (cherry picked from commit a2797c8) # Conflicts: # CHANGELOG.md # api/cosmos/group/v1/query.pulsar.go # api/cosmos/group/v1/query_grpc.pb.go # api/cosmos/orm/module/v1alpha1/module.pulsar.go # x/group/client/testutil/query.go # x/group/keeper/grpc_query_test.go # x/group/query.pb.go

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com> (cherry picked from commit a2797c8) # Conflicts: # CHANGELOG.md # x/group/keeper/grpc_query_test.go

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <huang@crypto.com> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <marbar3778@yahoo.com> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <marbar3778@yahoo.com> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <julien@rbrt.fr> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo Medica <facundomedica@gmail.com> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

…#15476) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

atheeshp and others added 6 commits January 31, 2023 14:24

proto

5bffaf5

proto-gen

1a6d7c2

Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/query-groups

2b1157b

Merge branch 'ap/query-groups' of github.com:cosmos/cosmos-sdk into a…

bbcb776

…p/query-groups

add keeper logic

17777ed

add tests

3f0dd02

github-actions bot added C:CLI C:x/group labels Feb 2, 2023

atheeshp and others added 4 commits February 2, 2023 10:58

Merge branch 'main' into ap/query-groups

dbf7d75

add tests

0e37779

Merge branch 'ap/query-groups' of github.com:cosmos/cosmos-sdk into a…

03070e5

…p/query-groups

changelog

b5c4415

atheeshp marked this pull request as ready for review February 2, 2023 09:53

atheeshp requested a review from a team as a code owner February 2, 2023 09:53

github-prbot requested a review from a team February 2, 2023 09:54

atheeshp requested a review from amaury1093 February 2, 2023 09:54

github-prbot requested review from tac0turtle and julienrbrt and removed request for a team February 2, 2023 09:54

tac0turtle approved these changes Feb 2, 2023

View reviewed changes

julienrbrt reviewed Feb 2, 2023

View reviewed changes

proto/cosmos/group/v1/query.proto Outdated Show resolved Hide resolved

julienrbrt added the TODO:backport-v0.47.1 label Feb 2, 2023

likhita-809 approved these changes Feb 2, 2023

View reviewed changes

proto/cosmos/group/v1/query.proto Outdated Show resolved Hide resolved

x/group/client/cli/query.go Outdated Show resolved Hide resolved

atheeshp and others added 5 commits February 2, 2023 22:18

review changes

a4d47af

Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/query-groups

d81218c

make proto-gen

e605a97

Update proto/cosmos/group/v1/query.proto

bc3ec26

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

Update x/group/client/cli/query.go

cb1d8ac

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

julienrbrt approved these changes Feb 2, 2023

View reviewed changes

atheeshp added 2 commits February 3, 2023 14:49

fix tests

4bc0156

Merge branch 'ap/query-groups' of github.com:cosmos/cosmos-sdk into a…

d1fd9bb

…p/query-groups

atheeshp enabled auto-merge (squash) February 3, 2023 09:23

Merge branch 'main' into ap/query-groups

4ed00ea

atheeshp merged commit a2797c8 into main Feb 3, 2023

atheeshp deleted the ap/query-groups branch February 3, 2023 10:00

julienrbrt removed the TODO:backport-v0.47.1 label Mar 20, 2023

This was referenced Mar 20, 2023

feat: add query groups in x/group (backport #14879) #15475

Merged

feat: add query groups in x/group (backport #14879) #15476

Merged

julienrbrt added a commit that referenced this pull request Mar 20, 2023

feat: add query groups in x/group (backport #14879) (#15475)

a0497b7

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

julienrbrt pushed a commit that referenced this pull request Mar 20, 2023

feat: add query groups in x/group (backport #14879) (#15476)

cc39456

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

faddat mentioned this pull request Mar 28, 2023

update linter to 1521 ChihuahuaChain/cosmos-sdk#6

Closed

19 tasks

tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023

feat: add query groups in x/group (cosmos#14879)

37428b1

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

faddat mentioned this pull request Jun 8, 2023

barberry realiotech/cosmos-sdk#30

Merged

0xstepit mentioned this pull request Jul 1, 2024

chore(cachemulti): add Copy method evmos/cosmos-sdk#52

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add query `groups` in `x/group` #14879

feat: add query `groups` in `x/group` #14879

atheeshp commented Feb 2, 2023

tac0turtle left a comment

likhita-809 left a comment •

edited

Loading

julienrbrt left a comment

julienrbrt commented Feb 2, 2023

atheeshp commented Feb 3, 2023

robert-zaremba commented Feb 3, 2023

julienrbrt commented Feb 3, 2023 •

edited

Loading

julienrbrt commented Mar 20, 2023

mergify bot commented Mar 20, 2023 •

edited

Loading

julienrbrt commented Mar 20, 2023

mergify bot commented Mar 20, 2023 •

edited

Loading

feat: add query groups in x/group #14879

feat: add query groups in x/group #14879

Conversation

atheeshp commented Feb 2, 2023

Description

Author Checklist

Reviewers Checklist

tac0turtle left a comment

Choose a reason for hiding this comment

likhita-809 left a comment • edited Loading

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt commented Feb 2, 2023

atheeshp commented Feb 3, 2023

robert-zaremba commented Feb 3, 2023

julienrbrt commented Feb 3, 2023 • edited Loading

julienrbrt commented Mar 20, 2023

mergify bot commented Mar 20, 2023 • edited Loading

✅ Backports have been created

julienrbrt commented Mar 20, 2023

mergify bot commented Mar 20, 2023 • edited Loading

✅ Backports have been created

feat: add query `groups` in `x/group` #14879

feat: add query `groups` in `x/group` #14879

likhita-809 left a comment •

edited

Loading

julienrbrt commented Feb 3, 2023 •

edited

Loading

mergify bot commented Mar 20, 2023 •

edited

Loading

mergify bot commented Mar 20, 2023 •

edited

Loading