Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove support for NoOptDefaultValue #14985

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios commented Feb 9, 2023

Description

Removes NoOptDefault Value flag from autcocli due to a bug in pflag.
Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review February 9, 2023 19:37
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner February 9, 2023 19:37
@julienrbrt
Copy link
Member

This is what had to be backported to v0.47 right?

@JeancarloBarrios
Copy link
Contributor Author

This is what had to be backported to v0.47 right?

Yes ! Sorry forgot to tag

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 9, 2023
@JeancarloBarrios JeancarloBarrios merged commit 3c53870 into main Feb 9, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/remove-no-opt-from-autocli branch February 9, 2023 21:13
mergify bot pushed a commit that referenced this pull request Feb 9, 2023
@@ -101,9 +101,6 @@ message FlagOptions {
// default_value is the default value as text.
string default_value = 4;

// default value is the default value as text if the flag is used without any value.
string no_opt_default_value = 5;

// deprecated is the usage text to show if this flag is deprecated.
string deprecated = 6;
Copy link
Member

@julienrbrt julienrbrt Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, as we are deleting a field, maybe we should decrease the identifier of the others too, given it has not been yet released. cc @JeancarloBarrios

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True I missed that thanks !!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we don't do this actually... so the issue is that this is part of the api module not 0.47 at all. So backporting doesn't really do anything. The thing that we need to do is tag api and then backport the required API module version to 0.47. Removing the field is one thing, but changing the numbers really would break any case that someone built their binary with an earlier version of api. This is maybe the first case in the wild where the issues raised in ADR 046 can be observed. Let's discuss a tagging/versioning strategy next week.

Copy link
Member

@julienrbrt julienrbrt Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Didn't notice the generated proto was pulsar.
One small unrelated issue is that now API possibly not support v0.47 entirely given CometBFT (#14899)

@julienrbrt julienrbrt mentioned this pull request Feb 9, 2023
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
RiccardoM added a commit to desmos-labs/cosmos-sdk that referenced this pull request Jan 9, 2024
RiccardoM added a commit to desmos-labs/cosmos-sdk that referenced this pull request Feb 8, 2024
RiccardoM added a commit to desmos-labs/cosmos-sdk that referenced this pull request Feb 20, 2024
dadamu pushed a commit to desmos-labs/cosmos-sdk that referenced this pull request Apr 9, 2024
dadamu pushed a commit to desmos-labs/cosmos-sdk that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants