Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: keyring test refactor #15039

Merged
merged 10 commits into from
Feb 17, 2023
Merged

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#14976


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JulianToledano JulianToledano requested a review from a team as a code owner February 15, 2023 15:19
JulianToledano and others added 3 commits February 15, 2023 23:54
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/keyring_test.go Outdated Show resolved Hide resolved
JulianToledano and others added 2 commits February 16, 2023 09:51
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt linked an issue Feb 17, 2023 that may be closed by this pull request
@julienrbrt julienrbrt merged commit 0debb58 into cosmos:main Feb 17, 2023
@JulianToledano JulianToledano deleted the feat/keyring-test-refactor branch February 17, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor of keyring tests
3 participants