Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement RegisterServices for CoreAPI in module manager #15133

Merged
merged 26 commits into from
Mar 2, 2023
Merged

feat: Implement RegisterServices for CoreAPI in module manager #15133

merged 26 commits into from
Mar 2, 2023

Conversation

facundomedica
Copy link
Member

Description

Closes: #14688

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

aaronc
aaronc reviewed Feb 23, 2023
View reviewed changes
types/module/configurator.go Outdated Show resolved Hide resolved
types/module/configurator.go Outdated Show resolved Hide resolved
@facundomedica facundomedica marked this pull request as ready for review February 23, 2023 19:31
@facundomedica facundomedica requested a review from a team as a code owner February 23, 2023 19:31
@github-prbot github-prbot requested review from a team, aaronc and tac0turtle and removed request for a team February 23, 2023 19:32
tac0turtle
tac0turtle approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

aaronc
aaronc reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to tag core and then update this PR against that. I made a PR so that RegisterServices in core now returns an error

@facundomedica
Copy link
Member Author

facundomedica commented Feb 28, 2023 •
edited
Loading

I think we need to tag core and then update this PR against that. I made a PR so that RegisterServices in core now returns an error

will tag now

EDIT: tagged core/v0.6.0. BTW, we need to fix the changelog

@facundomedica
Copy link
Member Author

@aaronc do we need to modify ExtractAutoCLIOptions and simapp's TestRunMigrations? Both check if module is HasServices

@aaronc
Copy link
Member

aaronc commented Feb 28, 2023

@aaronc do we need to modify ExtractAutoCLIOptions and simapp's TestRunMigrations? Both check if module is HasServices

I'm assuming it's just the legacy HasServices right? But yes, those should check for the core API HasServices

@facundomedica facundomedica requested a review from aaronc February 28, 2023 20:52
aaronc
aaronc approved these changes Mar 2, 2023
View reviewed changes
runtime/services/autocli.go
if haveServices {
moduleOptions[modName] = modOptions
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can reduce code duplication a lot here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've also did the correct implementation of RegisterServices in the autocli configurator. We should be good to merge now 👌

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've also did the correct implementation of RegisterServices in the autocli configurator. We should be good to merge now 👌

@facundomedica facundomedica enabled auto-merge (squash) March 2, 2023 16:44
@facundomedica facundomedica disabled auto-merge March 2, 2023 16:45
@facundomedica facundomedica changed the title feat: Implement RegisterServices for CoreAPI modules feat: Implement RegisterServices for CoreAPI in module manager Mar 2, 2023
@facundomedica facundomedica merged commit 14ba024 into main Mar 2, 2023
@julienrbrt julienrbrt deleted the facu/coreapi-service-2 branch March 2, 2023 21:49
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@facundomedica @tac0turtle
feat: Implement RegisterServices for CoreAPI in module manager (cosmo…
1d3e6a1 
…s#15133)

Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc aaronc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support core API service registration
3 participants
@facundomedica @aaronc @tac0turtle