Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --initial-height flag to cli init cmd #15147

Merged
merged 5 commits into from
Feb 24, 2023

Conversation

fragwuerdig
Copy link
Contributor

@fragwuerdig fragwuerdig commented Feb 24, 2023

Description

Closes: #15027.

Added flag "--initial-height" to the init command. Tested manually. LMK if that needs to be covered.

The parameter needs to be provided as int, because the genesis doc accepts int. However, this PR defaults negative block heights to 1.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@fragwuerdig fragwuerdig requested a review from a team as a code owner February 24, 2023 11:42
@github-prbot github-prbot requested review from a team, aaronc and tac0turtle and removed request for a team February 24, 2023 11:42
@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Feb 24, 2023
@fragwuerdig fragwuerdig changed the title add initial height flag to cli init cmd feat: add initial height flag to cli init cmd Feb 24, 2023
@fragwuerdig fragwuerdig force-pushed the feat/genutil-add-starting-height branch from 6a45baf to 63dd7e8 Compare February 24, 2023 12:03
@fragwuerdig fragwuerdig changed the title feat: add initial height flag to cli init cmd feat: add --initial-height flag to cli init cmd Feb 24, 2023
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some tests please ?

CHANGELOG.md Outdated
@@ -78,6 +78,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/gov,cli) [#14718](https://github.com/cosmos/cosmos-sdk/pull/14718) Added `AddGovPropFlagsToCmd` and `ReadGovPropFlags` functions.
* (x/bank) [#14894](https://github.com/cosmos/cosmos-sdk/pull/14894) Return a human readable denomination for IBC vouchers when querying bank balances. Added a `ResolveDenom` parameter to `types.QueryAllBalancesRequest` and `--resolve-denom` flag to `GetBalancesCmd()`.
* (x/groups) [#14879](https://github.com/cosmos/cosmos-sdk/pull/14879) Add `Query/Groups` query to get all the groups.
* (x/genutil,cli) [#15147](https://github.com/cosmos/cosmos-sdk/pull/15147) Add `--initial-height` flag to cli init cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also specify what initial-height flag does here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok... Took care of that. Please, resolve if appropriate.

x/genutil/client/cli/init.go Fixed Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

@julienrbrt julienrbrt merged commit b53be68 into cosmos:main Feb 24, 2023
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 20, 2023
(cherry picked from commit b53be68)

# Conflicts:
#	CHANGELOG.md
#	x/genutil/client/cli/init.go
@fragwuerdig fragwuerdig deleted the feat/genutil-add-starting-height branch March 20, 2023 14:43
julienrbrt added a commit that referenced this pull request Mar 20, 2023
…5467)

Co-authored-by: Till Ziegler <tz@schoeneweide.tk>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(client) add --starting-height flag to simd init
4 participants