refactor: Use anyutil instead of any #15322
Conversation
github-actions
bot
added
C:CLI
C:collections
C:Confix
github-actions
bot
removed
C:x/evidence
C:CLI
C:x/upgrade
C:x/circuit
C:Hubl
| cosmossdk.io/core => ./core | ||
| cosmossdk.io/x/tx => ./x/tx |
There was a problem hiding this comment.
What's the process here to remove short-lived replaces? Should I tag a version right after, or wait a bit (given e.g. there are a lot of other changes in x/tx these days).
There was a problem hiding this comment.
yes, we remove these replaces by tagging a version from what I know. But IDK when we do that
There was a problem hiding this comment.
just curious to know why are we using these replace directives here and other go mods ?
There was a problem hiding this comment.
Actually lately (for log, collections and math) we've been using pseudo version of the latest commit from main / the branch.
There was a problem hiding this comment.
just curious to know why are we using these replace directives here and other go mods ?
Here are my steps to why I added them:
- I replaced all
anywithanyutilin go code - it happened in sdk, core and x/tx
- I bumped to beta.3 in sdk, core, and x/tx
- I got an error saying that sdk imports core, which imports cosmos-proto (beta.2), which doesn't have anyutil
- I added this replace and it worked.
There was a problem hiding this comment.
Actually lately (for log, collections and math) we've been using pseudo version of the latest commit from main / the branch.
Should I switch to a pseudo version of the latest commit of this branch? Not sure which is best compared to replace (I prefer the latter)
There was a problem hiding this comment.
I believe the reason with the first, and that it's one less PR (when we need not to miss a replace), and dependabot takes care of the rest if it's a pseudo version when we tag something.
However, it makes more clear with replace what still needs to be tagged 👍🏾
Description
ref: cosmos/cosmos-proto#101
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change