Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WIP) : rotate operator key #15494

Closed
wants to merge 54 commits into from
Closed

feat(WIP) : rotate operator key #15494

wants to merge 54 commits into from

Conversation

atheeshp
Copy link
Contributor

Description

ref: #3863

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

for _, valAddrStr := range maturedRotatedValAddrs {
valAddr, err := sdk.ValAddressFromBech32(valAddrStr)
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 21, 2023
@atheeshp atheeshp removed the Stale label Apr 21, 2023
func (k Keeper) updateValidatorOperatorKey(ctx sdk.Context, validator types.Validator, delAddr sdk.AccAddress, newValAddr, curValAddr sdk.ValAddress) {
validator.OperatorAddress = newValAddr.String()
k.SetValidator(ctx, validator)
k.SetValidatorByConsAddr(ctx, validator)

Check warning

Code scanning / gosec

Errors unhandled.

Errors unhandled.
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 26, 2023
@github-actions github-actions bot closed this May 31, 2023
@atheeshp atheeshp reopened this Jun 2, 2023
@github-actions github-actions bot removed the Stale label Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Jul 3, 2023
@tac0turtle
Copy link
Member

closing this for now but we will reopen it when the team is ready to work on it

@tac0turtle tac0turtle closed this Jul 26, 2023
@tac0turtle tac0turtle deleted the ap/rotate_oper_key branch February 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants