Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove ignite cli #15521

Merged
merged 1 commit into from
Mar 23, 2023
Merged

docs: remove ignite cli #15521

merged 1 commit into from
Mar 23, 2023

Conversation

tac0turtle
Copy link
Member

Description

ignite cli lags sdk and has been causing many issues for users, since we dont coordinate with them we shouldnt recommend the product for users

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner March 23, 2023 09:17
julienrbrt
julienrbrt approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faddat will be happy :D

@julienrbrt julienrbrt merged commit 750d125 into main Mar 23, 2023
@julienrbrt julienrbrt deleted the marko/remove_ignite branch March 23, 2023 09:31
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 23, 2023
@tac0turtle @mergify
docs: remove ignite cli (#15521)
d3fa5f0 
(cherry picked from commit 750d125)

# Conflicts:
#	docs/architecture/adr-057-app-wiring.md
@mergify mergify bot mentioned this pull request Mar 23, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Mar 23, 2023
@mergify @tac0turtle
docs: remove ignite cli (backport #15521) (#15523)
bd64c81 
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
@fmorency fmorency mentioned this pull request Sep 1, 2023
Closed
@fmorency fmorency mentioned this pull request Sep 19, 2023
Open
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samricotta samricotta samricotta approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @julienrbrt @samricotta