Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(x/distribution): write integration tests #15569

Merged
merged 49 commits into from
Apr 13, 2023
Merged

test(x/distribution): write integration tests #15569

merged 49 commits into from
Apr 13, 2023

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Mar 28, 2023 •
edited
Loading

Description

Ref: #14678 #14676

The test setup is improved from julien's #15556 and a bit of own research.
This PR shows tests from tests/integration/distribution written to x/distribution using new testing framework setup and is in progress
It also removes the duplicate tests from tests/integration/distribution which are already tested in x/distribution module using mocks

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/distribution distribution module related label Mar 28, 2023
julienrbrt
julienrbrt reviewed Mar 30, 2023
View reviewed changes
testutil/integration/integration_setup.go Outdated Show resolved Hide resolved
testutil/integration/integration_setup.go Outdated Show resolved Hide resolved
x/distribution/keeper/integration_test.go Outdated Show resolved Hide resolved
@kocubinski kocubinski self-assigned this Mar 30, 2023
@likhita-809 likhita-809 marked this pull request as ready for review April 4, 2023 08:40
@likhita-809 likhita-809 requested a review from a team as a code owner April 4, 2023 08:40
julienrbrt
julienrbrt reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @likhita-809!
I have not checked thoroughly everything yet, as the sonarcloud job got skipped for some reason (https://github.com/cosmos/cosmos-sdk/actions/runs/4605272106/jobs/8139795495?pr=15569), I'll be checking more after it gets triggered again (as it gives a quick overview if the surface tested decreased).

x/distribution/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/distribution/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt changed the title feat: Integration testing framework setup PoC (x/distribution) test(x/distribution): write integration tests Apr 4, 2023
@likhita-809 likhita-809 mentioned this pull request Apr 11, 2023
Merged
19 tasks
julienrbrt
julienrbrt previously approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great to see the test duplication diminish!

testutil/integration/router.go Outdated Show resolved Hide resolved
testutil/integration/router.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 13, 2023
@tac0turtle tac0turtle enabled auto-merge (squash) April 13, 2023 09:00
@tac0turtle tac0turtle merged commit 495ef01 into main Apr 13, 2023
@tac0turtle tac0turtle deleted the likhita/poc branch April 13, 2023 10:06
@julienrbrt julienrbrt mentioned this pull request Apr 18, 2023
Closed
cool-develope pushed a commit that referenced this pull request Apr 26, 2023
@likhita-809 @tac0turtle @cool-develope
test(x/distribution): write integration tests (#15569)
2ce0759 
Co-authored-by: Marko <marbar3778@yahoo.com>
@likhita-809 likhita-809 mentioned this pull request May 22, 2023
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees

@mark-rushakoff mark-rushakoff

@julienrbrt julienrbrt

@samricotta samricotta

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@likhita-809 @tac0turtle @julienrbrt @mark-rushakoff @kocubinski @samricotta