-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SigVerificationDecorator ante handler with x/tx legacy amino json sign mode handler #15713
Conversation
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
…k into kocubinski/sigverify-v2
… into kocubinski/x-tx-decode
… into kocubinski/x-tx-decode
This comment has been minimized.
This comment has been minimized.
…k into kocubinski/sigverify-v2
@@ -46,7 +46,7 @@ func marshalTimestamp(message protoreflect.Message, writer io.Writer) error { | |||
|
|||
// MaxDurationSeconds the maximum number of seconds (when expressed as nanoseconds) which can fit in an int64. | |||
// gogoproto encodes google.protobuf.Duration as a time.Duration, which is 64-bit signed integer. | |||
const MaxDurationSeconds = int64(math.MaxInt64/int(1e9)) - 1 | |||
const MaxDurationSeconds = int64(math.MaxInt64)/1e9 - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since math.MaxInt64
is an untyped constant, an explicit cast is required to support 32 arch, e.g. our arm docker builds. See golang/go#23086.
This was surfaced bringing latest x/tx into simapp builds.
17175ce
to
fe98dac
Compare
Is #15822 an alternative to this or are these complementary? |
This should be probably be closed now.. it's an alternative. |
Description
Closes: #15698
Includes: #15414
This patch deprecates calls to legacytx.StdSignBytes and therefore calls to LegacyMsg.GetSignBytes.
In the default ante handler a new code path is introduced by opting into the x/tx SignModeHandler by setting
ante.HandlerOptions.SignModeHandlerV2
. This could also be an API break onHandlerOptions.SignModeHandler
if we choose to do so.The usage of
StdSignBytes
in client/tx is a straightforward refactor to depend on x/tx signers.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change