ci: lint all modules even if one module fails #15819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
JeancarloBarrios and
likhita-809
and removed request for
a team
|
Moving to draft temporarily while I fix issues I didn't reproduce on my workstation. |
The previous implementation stopped linting when it encountered its first module that failed the linter. Now, use a more idiomatic find|xargs pattern, which will run every module and exit non-zero if any module fails to lint. This will speed up the feedback cycle on CI in the event that multiple modules fail linting. Also change the script extension to .bash to make it clear to consumers that this script requires bash, not sh; and make the script executable so that CI can execute it directly instead of calling sh $script.
mark-rushakoff
force-pushed
the
mr/ci-lint-script-all-modules
branch
from
20e836b to
7f87a7a
Compare
This makes it simpler to tell, at a glance, how long each package takes to lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation stopped linting when it encountered its first module that failed the linter.
Now, use a more idiomatic find|xargs pattern, which will run every module and exit non-zero if any module fails to lint. This will speed up the feedback cycle on CI in the event that multiple modules fail linting.
Also change the script extension to .bash to make it clear to consumers that this script requires bash, not sh; and make the script executable so that CI can execute it directly instead of calling sh $script.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...