-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(abci): add msg index to event #15845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well do this in the Comet 0.38 branch as it'll just create more work of us if you do it against main
.
Could we merge it into main. Happy to handle the merge into 0.38. |
my point is there is no point to merge to main -- we're literally going to do the exact same change in the base branch immediately. |
this is orthagonal to 0.38, i dont get what the overlap is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do we need to add a note in the UPGRADING.md because it might break some tooling?
It's failing because it's matching against the raw logs, I've fix one in which I iterate through events to find the right event type. But maybe we would like to have an easier way like doing |
i was going to rewrite these tests in a dfferent pr to unit tests, dont think these need to be e2e |
lmk if you'd like me to revert my commits |
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>
* refactor(abci): add msg index to event (cosmos#15845) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com> * fix e2e tests * another e2e fix * e2e * reset groupID * e2e * switch check to events * e2e * e2e --------- Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>
Description
Closes: #15017
Logs now do not contain events associated to messages. The msg_index was added to the event itself, this avoids duplication of data
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change