build: use cosmos/gogoproto@v1.4.8 for optimized registry merge #15862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Confix
mark-rushakoff
force-pushed
the
mr/use-optimized-registry-merge
branch
from
16a145b
to
0dde947
Compare
mark-rushakoff
changed the title
mark-rushakoff
changed the title
julienrbrt
approved these changes
Apr 18, 2023
simapp/go.mod
Outdated
| @@ -19,8 +19,8 @@ require ( | |||
| github.com/cometbft/cometbft v0.37.1-0.20230411132551-3a91d155e664 | |||
| github.com/cosmos/cosmos-db v1.0.0-rc.1 | |||
| // this version is not used as it is always replaced by the latest Cosmos SDK version | |||
| github.com/cosmos/cosmos-sdk v0.48.0 | |||
| github.com/cosmos/gogoproto v1.4.7 | |||
| github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230418140744-0dde947d0ab7 | |||
There was a problem hiding this comment.
simd version --long is looks nicer if we revert this one.
There was a problem hiding this comment.
Oh I see, because these two files have the replace directive. I'll push a change correcting these two.
tests/go.mod
Outdated
| @@ -19,8 +19,8 @@ require ( | |||
| github.com/cosmos/cosmos-db v1.0.0-rc.1 | |||
| github.com/cosmos/cosmos-proto v1.0.0-beta.3 | |||
| // this version is not used as it is always replaced by the latest Cosmos SDK version | |||
| github.com/cosmos/cosmos-sdk v0.48.0 | |||
| github.com/cosmos/gogoproto v1.4.7 | |||
| github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230418140744-0dde947d0ab7 | |||
mark-rushakoff
added a commit
that referenced
this pull request
Apr 19, 2023
It used to be set to 5 tries, but that was taking over an hour. After some improvements (particularly #15875 and #15862), it's running much faster due to reduced allocations. Since the nondeterminism tests are no longer the bottleneck, increase the tries per seed by 1 so that it is still no longer the bottleneck, but so that we also get more confidence that results are deterministic.
8 tasks
cool-develope
pushed a commit
that referenced
this pull request
Apr 26, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to bring in cosmos/gogoproto#61, which spreads work for registry merging across all available cores.
In addition to the other performance improvements in v1.4.8, the sim-app-nondeterminism tests and the CLI complete much more quickly.