refactor(codec)!: update codec to x/tx v0.6.0 #15873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
JeancarloBarrios and
julienrbrt
and removed request for
a team
kocubinski
reviewed
Apr 19, 2023
| @@ -26,15 +26,15 @@ type ( | |||
| // GetMsgAnySigners returns the signers of the given message encoded in a protobuf Any | |||
| // as well as the decoded google.golang.org/protobuf/proto.Message that was used to | |||
| // extract the signers so that this can be used in other contexts. | |||
| GetMsgAnySigners(msg *types.Any) ([]string, protov2.Message, error) | |||
There was a problem hiding this comment.
Does changing this interface contract require a mention in the CHANGELOG?
There was a problem hiding this comment.
No, it's new anyway and there are CHANGELOG entries already for this addition
kocubinski
reviewed
Apr 19, 2023
19 tasks
kocubinski
reviewed
Apr 19, 2023
kocubinski
reviewed
Apr 26, 2023
x/auth/tx/config/config.go
Outdated
| // - Provide static prefix there exported from config? | ||
| // - Just do as below? | ||
| AddressCodec: authcodec.NewBech32Codec(sdkConfig.GetBech32AccountAddrPrefix()), | ||
| ValidatorCodec: authcodec.NewBech32Codec(sdkConfig.GetBech32ValidatorAddrPrefix()), |
There was a problem hiding this comment.
I'd like some feedback re the above comments. What approach do you think is best?
There was a problem hiding this comment.
We will need to find an alternative way to do this that pulls the codecs from the depinject container. I think it's fine for now as I did something similar and I intend to address in a follow up.
mark-rushakoff
approved these changes
Apr 27, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #11275
Pulls out the
codecupdates from #15284 into a smaller PRAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change