-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add moduleStateCb to allow access moduleState in sim test #15903
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d58f032
add moduleStateCb to access module state
mmsqe ade55cd
rm unused type
mmsqe 4e002da
add change doc
mmsqe faf5d37
fix doc
mmsqe be9f69b
Merge branch 'main' into module_state_cb
mmsqe 6177835
Update testutil/sims/state_helpers.go
mmsqe 546f489
Merge branch 'main' into module_state_cb
mmsqe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,11 +177,6 @@ type AppStateFn func(r *rand.Rand, accs []Account, config Config) ( | |
appState json.RawMessage, accounts []Account, chainId string, genesisTimestamp time.Time, | ||
) | ||
|
||
// AppStateFnWithExtendedCb returns the app state json bytes and the genesis accounts | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ACK because identical to AppStateFn and unused. |
||
type AppStateFnWithExtendedCb func(r *rand.Rand, accs []Account, config Config) ( | ||
appState json.RawMessage, accounts []Account, chainId string, genesisTimestamp time.Time, | ||
) | ||
|
||
// RandomAccountFn returns a slice of n random simulation accounts | ||
type RandomAccountFn func(r *rand.Rand, n int) []Account | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Iteration over map