feat: add moduleStateCb to allow access moduleState in sim test (backport #15903) #15924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 4d41a87) # Conflicts: # CHANGELOG.md
julienrbrt
approved these changes
Apr 24, 2023
julienrbrt
reviewed
Apr 24, 2023
| appState json.RawMessage, accounts []Account, chainId string, genesisTimestamp time.Time, | ||
| ) | ||
| // Deprecated: Use AppStateFn instead. This will be removed in a future relase. | ||
| type AppStateFnWithExtendedCb AppStateFn |
There was a problem hiding this comment.
Even if not used, this makes v0.47 still not API breaking: #15903 (comment).
It will be then deleted in v0.48.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+165
to
+173
| for name, state := range map[string]proto.Message{ | ||
| stakingtypes.ModuleName: stakingState, | ||
| banktypes.ModuleName: bankState, | ||
| } { | ||
| if moduleStateCb != nil { | ||
| moduleStateCb(name, state) | ||
| } | ||
| rawState[name] = cdc.MustMarshalJSON(state) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…port cosmos#15903) (cosmos#15924) Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #15903 done by Mergify.
Cherry-pick of 4d41a87 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com