-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(x/slashing): write integration tests #15928
Conversation
…ita/slash-integrations
…ita/slash-integrations
…ita/slash-integrations
…ita/slash-integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but like Marko said, I think we should rather have integration tests via msgs. Presently, it isn't clear what is a unit test and what is an integration test for slashing.
I think we should be coherent. Currently, the message server isn't used at all in the rewritten integration tests.
Nice again to see those e2e to be deleted!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@likhita-809 could you revert the app.go changes? A PR already fixed it (and there is a conflict here now). |
…ita/slash-integrations
Description
ref: #14145
This PR refactors the slashing integration tests to use new testing framework setup and de-duplicates some code.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change