Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(baseapp): set vote info to latest votes #15930

Merged
merged 4 commits into from
Apr 25, 2023
Merged

refactor(baseapp): set vote info to latest votes #15930

merged 4 commits into from
Apr 25, 2023

Conversation

tac0turtle
Copy link
Member

Description

This pr sets the latest votes to voteinfo in prepare and process proposal. The Prepare Proposal step introduced a conversion from ExtendedCommitInfo to abci.VoteInfo.

The ExtendedVoteInfo is meant to be used with vote extensions which are not handled yet

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review April 24, 2023 16:16
@tac0turtle tac0turtle requested a review from a team as a code owner April 24, 2023 16:16
@github-prbot github-prbot requested review from a team, aaronc and likhita-809 and removed request for a team April 24, 2023 16:17
aaronc
aaronc reviewed Apr 24, 2023
View reviewed changes
baseapp/abci.go
@@ -341,7 +341,7 @@ func (app *BaseApp) ProcessProposal(req abci.RequestProcessProposal) (resp abci.
app.setState(runTxProcessProposal, emptyHeader)

app.processProposalState.ctx = app.getContextForProposal(app.processProposalState.ctx, req.Height).
WithVoteInfos(app.voteInfos).
WithVoteInfos(req.ProposedLastCommit.Votes). // this is a set of votes that are not finalized yet, wait for commit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just straight up remove VoteInfo from context?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but that's orthogonal, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. This is backportable

Copy link
Member Author

@tac0turtle tac0turtle Apr 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may not be a usecase for this today but for things like optimistic execution it will be needed. Might as well leave it

EDIT: it could be removed but this would be a larger breaking chnage. I would be up for removing it in cometinfo pr though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im worried about backporting this if anyone is using votes, it could cause unforseen changes. Lets leave it for 0.50. Ill add a changelog then merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would it be used for optimistic execution?

alexanderbez
alexanderbez approved these changes Apr 24, 2023
View reviewed changes
baseapp/abci.go
@@ -341,7 +341,7 @@ func (app *BaseApp) ProcessProposal(req abci.RequestProcessProposal) (resp abci.
app.setState(runTxProcessProposal, emptyHeader)

app.processProposalState.ctx = app.getContextForProposal(app.processProposalState.ctx, req.Height).
WithVoteInfos(app.voteInfos).
WithVoteInfos(req.ProposedLastCommit.Votes). // this is a set of votes that are not finalized yet, wait for commit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but that's orthogonal, no?

@alexanderbez
Copy link
Contributor

@tac0turtle this should be backported to 0.47 I think.

@tac0turtle tac0turtle enabled auto-merge April 25, 2023 08:40
@tac0turtle tac0turtle added this pull request to the merge queue Apr 25, 2023
Merged via the queue into main with commit 91872ab Apr 25, 2023
@tac0turtle tac0turtle deleted the marko/set_vote_info branch April 25, 2023 08:57
bizk added a commit to Zondax/cosmos-sdk that referenced this pull request Apr 25, 2023
@bizk @kocubinski
@tac0turtle @samricotta @julienrbrt
Linting revision
584e9d2 
* solved lint issues

* feat(x/tx): API improvements (cosmos#15871)

* refactor(baseapp): set vote info to latest votes (cosmos#15930)

* refactor(staking, slashing, signing, misc): remove aliases from types/math.go (cosmos#15902)

* fix(autocli): fix simapp enhancing (cosmos#15906)

* fix lint on armor.go

* ran make lint-fix

---------

Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@aaronc aaronc

@alexanderbez alexanderbez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @alexanderbez @aaronc