Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hubl): cache bech32 prefix #15954

Merged
merged 8 commits into from
Apr 26, 2023
Merged

feat(hubl): cache bech32 prefix #15954

merged 8 commits into from
Apr 26, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15906 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review April 26, 2023 14:06
@julienrbrt julienrbrt requested a review from a team as a code owner April 26, 2023 14:06
@julienrbrt julienrbrt requested a review from aaronc April 26, 2023 14:12
@github-prbot github-prbot requested review from a team and JeancarloBarrios and removed request for a team April 26, 2023 14:13
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

not needed here, because it is unreleased software (both hubl and client/v2).

@aaronc aaronc self-assigned this Apr 26, 2023
client/v2/autocli/app.go Show resolved Hide resolved
client/v2/autocli/flag/address.go Outdated Show resolved Hide resolved
@aaronc aaronc removed their assignment Apr 26, 2023
@julienrbrt julienrbrt enabled auto-merge April 26, 2023 16:01
@julienrbrt julienrbrt added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 1179285 Apr 26, 2023
@julienrbrt julienrbrt deleted the julien/cache-bech32 branch April 26, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants