feat: support extension options for build tx #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include extension option used with ethermint dynamic fee tx * for more info, see https://github.com/evmos/ethermint/blob/main/proto/ethermint/types/v1/dynamic_fee.proto
mmsqe
force-pushed
the
support_extension
branch
from
42b9a31 to
e24161c
Compare
github-prbot
requested review from
a team,
alexanderbez and
atheeshp
and removed request for
a team
alexanderbez
approved these changes
Apr 29, 2023
julienrbrt
reviewed
Apr 29, 2023
client/tx/factory.go
Outdated
| @@ -281,6 +283,12 @@ func (f Factory) PreprocessTx(keyname string, builder client.TxBuilder) error { | |||
| return f.preprocessTxHook(f.chainID, key.GetType(), builder) | |||
| } | |||
|
|
|||
| // WithExtensionOptions returns a Factory with given extension options added to the existing options. | |||
There was a problem hiding this comment.
It would be interesting to explain here the use case for it.
There was a problem hiding this comment.
Added, see if it's ok.
mmsqe
commented
Apr 30, 2023
mmsqe
added a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
May 27, 2023
julienrbrt
pushed a commit
that referenced
this pull request
May 28, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
kakysha
pushed a commit
to InjectiveLabs/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change