Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(genutil): remove duplicate tests from genutil integration tests #16034

Merged
merged 1 commit into from
May 4, 2023

Conversation

likhita-809
Copy link
Contributor

Description

ref: #14145

This PR removes the duplicate tests from genutil integration tests as these were already covered in the module itself.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label May 4, 2023
@likhita-809 likhita-809 marked this pull request as ready for review May 4, 2023 14:11
@likhita-809 likhita-809 requested a review from a team as a code owner May 4, 2023 14:11
@tac0turtle tac0turtle added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 96730a5 May 4, 2023
@tac0turtle tac0turtle deleted the likhita/genutil-tests branch May 4, 2023 15:02
rllola pushed a commit to Zondax/cosmos-sdk that referenced this pull request May 11, 2023
@likhita-809 likhita-809 mentioned this pull request May 22, 2023
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants