-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(x/bank): write integration tests #16052
Conversation
could you add in the description where the duplicate tests are? cant seem to find them in the msg_server_test.go file |
sorry, my bad for writing the description incorrectly. I removed duplicate keeper tests not integration tests and all the msg server tests are already covered in msg_server_test.go file and there is no need to rewrite them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I guess we need to wait for the GH API to be less flaky to be able to merge this. |
Description
ref: #14145
This PR deduplicates bank's keeper tests and migrates bank's deterministic tests to use new testing framework.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change