Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rm GetSignBytes #16062

Merged
merged 27 commits into from
May 30, 2023
Merged

refactor!: rm GetSignBytes #16062

merged 27 commits into from
May 30, 2023

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented May 8, 2023

Description

Since the legacy amino JSON codec is now deprecated (#16110) and no longer used in production code paths (#16024) we can now remove a lot of unused code, code smells (global vars), and cyclic module dependencies.

The following cyclic dependencies are removed compared to main

/x/auth/ <-> /x/authz/
/x/auth/ <-> /x/group/
/x/authz/ <-> /x/group/
/x/authz/ <-> /x/gov/
/x/bank/ <-> /x/group/

cosmos/cosmos-sdk

  • Remove global legacy amino JSON codecs from modules.
  • Remove GetSignBytes implementations from messages which were using them.
  • The simulation.GetOrGenerate no longer requires a codec, and is now 4-arity instead of 5.

x/auth

  • Add global RegressionTestingAminoCodec to x/auth/legacytx package to replace the global codecs for use in regression tests. This should be deleted eventually.

cosmossdk.io/api

  • Add missing annotations on gov messages with Coins fields ensuring legacy consistency.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski force-pushed the kocubinski/rm-getsignbytes branch from f7707f1 to 3d7a2e7 Compare May 11, 2023 18:54
@tac0turtle tac0turtle self-assigned this May 30, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. the encoding tests are passing but later on during QA ill pull out a ledger to test things with

@github-actions github-actions bot removed C:CLI C:Rosetta Issues and PR related to Rosetta C:Cosmovisor Issues and PR related to Cosmovisor C:Confix Issues and PR related to Confix C:collections C:Hubl Tool: Hubl C:orm C:Store labels May 30, 2023
@kocubinski kocubinski added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit 737dcfd May 30, 2023
@kocubinski kocubinski deleted the kocubinski/rm-getsignbytes branch May 30, 2023 19:36
odeke-em added a commit that referenced this pull request Jun 1, 2023
Completes PR #16062 by removing sortJSON now that aminojson.Encoder
sorts fields by default. sortJSON was left as a TODO

Updates #2350
Updates #16254
odeke-em added a commit that referenced this pull request Jun 6, 2023
Completes PR #16062 by removing sortJSON now that aminojson.Encoder
sorts fields by default. sortJSON was left as a TODO

Updates #2350
Updates #16254
@kocubinski
Copy link
Member Author

This advanced #13025

odeke-em added a commit that referenced this pull request Jun 10, 2023
Completes PR #16062 by removing sortJSON now that aminojson.Encoder
sorts fields by default. sortJSON was left as a TODO

Updates #2350
Updates #16254
skyargos added a commit to shentufoundation/shentu that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants