-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: rm GetSignBytes #16062
Merged
Merged
refactor!: rm GetSignBytes #16062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Rosetta
Issues and PR related to Rosetta
C:x/auth
C:x/authz
C:x/bank
C:x/consensus
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/gov
C:x/group
C:x/mint
C:x/slashing
C:x/staking
C:x/tx
C:x/upgrade
labels
May 8, 2023
kocubinski
force-pushed
the
kocubinski/rm-getsignbytes
branch
from
May 8, 2023 19:50
78bd2be
to
025d165
Compare
github-actions
bot
added
C:CLI
C:collections
C:Confix
Issues and PR related to Confix
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Hubl
Tool: Hubl
C:orm
C:Store
C:x/circuit
C:x/nft
labels
May 11, 2023
kocubinski
force-pushed
the
kocubinski/rm-getsignbytes
branch
from
May 11, 2023 18:53
f5a89ab
to
f7707f1
Compare
kocubinski
force-pushed
the
kocubinski/rm-getsignbytes
branch
from
May 11, 2023 18:54
f7707f1
to
3d7a2e7
Compare
tac0turtle
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. the encoding tests are passing but later on during QA ill pull out a ledger to test things with
github-actions
bot
removed
C:CLI
C:Rosetta
Issues and PR related to Rosetta
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Confix
Issues and PR related to Confix
C:collections
C:Hubl
Tool: Hubl
C:orm
C:Store
labels
May 30, 2023
alexanderbez
approved these changes
May 30, 2023
This advanced #13025 |
9 tasks
3 tasks
5 tasks
skyargos
added a commit
to shentufoundation/shentu
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the legacy amino JSON codec is now deprecated (#16110) and no longer used in production code paths (#16024) we can now remove a lot of unused code, code smells (global vars), and cyclic module dependencies.
The following cyclic dependencies are removed compared to
main
cosmos/cosmos-sdk
GetSignBytes
implementations from messages which were using them.x/auth
RegressionTestingAminoCodec
to x/auth/legacytx package to replace the global codecs for use in regression tests. This should be deleted eventually.cosmossdk.io/api
Coins
fields ensuring legacy consistency.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change