fix: allow non-EOA accounts to stake in simulation #16068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
May 9, 2023
x/staking/simulation/operations.go
Outdated
| @@ -394,7 +394,7 @@ func SimulateMsgUndelegate( | |||
| } | |||
| // if simaccount.PrivKey == nil, delegation address does not exist in accs. Return error | |||
There was a problem hiding this comment.
Could you update this comment and explain the reasoning of why an error isn't returned.
There was a problem hiding this comment.
Thanks for the review. You are right, the comment there needs to be updated. Sent a fix for review.
julienrbrt
approved these changes
May 10, 2023
javiersuweijie
force-pushed
the
fix/15879/allow-non-eoa-staking-sim
branch
from
172d50c
to
7c71da5
Compare
|
Rebased to include merge conflicts in changelog |
julienrbrt
added
the
backport/v0.47.x
tac0turtle
approved these changes
May 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2023
Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit ddf51cc) # Conflicts: # CHANGELOG.md # x/staking/simulation/operations.go
tac0turtle
pushed a commit
that referenced
this pull request
May 12, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…6068) (cosmos#16130) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha
pushed a commit
to InjectiveLabs/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
…6068) (cosmos#16130) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15879
When running x/staking simulations, it is assumed that all delegators are EOA accounts with a private key. Staking module allows cosmwasm contracts and other modules as delegators so running the simulation when another module is the delegator will fail with
Removed the check in simulation to allow non-EOA accounts to stake.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change