Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename back TxExtensionOptionI #16145

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: rename back TxExtensionOptionI #16145

merged 3 commits into from
May 15, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented May 15, 2023

  • this change was included b0e82f9
  • to avoid breaking change from v0.46.x to v0.47.x

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mmsqe
rename back TxExtensionOptionI
b283c16 
* this change was included b0e82f9
* to avoid breaking change from v0.46.x to v0.47.x
mmsqe
mmsqe commented May 15, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review May 15, 2023 02:00
@mmsqe mmsqe requested a review from a team as a code owner May 15, 2023 02:00
@julienrbrt
Copy link
Member

julienrbrt commented May 15, 2023 •
edited
Loading

This makes sense but technically this brings a breaking change on people already on v0.47.0-v0.47.2.
Personally I think it is okay, as it was just a renaming (that probably shouldn't have went through), but I'd like the input of other.

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label May 15, 2023
@julienrbrt julienrbrt enabled auto-merge May 15, 2023 13:59
@julienrbrt julienrbrt added this pull request to the merge queue May 15, 2023
Merged via the queue into cosmos:main with commit d818a62 May 15, 2023
mergify bot pushed a commit that referenced this pull request May 15, 2023
@mmsqe @mergify
fix: rename back TxExtensionOptionI (#16145)
5ab29e2 
(cherry picked from commit d818a62)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request May 15, 2023
Merged
julienrbrt pushed a commit that referenced this pull request May 15, 2023
@mergify
fix: rename back TxExtensionOptionI (backport #16145) (#16154)
48c7a92
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
@mergify @roy-dydx
fix: rename back TxExtensionOptionI (backport cosmos#16145) (cosmos#1…
aaf5a4c 
…6154)
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
@mergify @kakysha
fix: rename back TxExtensionOptionI (backport cosmos#16145) (cosmos#1…
4f3dcbb 
…6154)
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @julienrbrt @alexanderbez