Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate prefix in staking keys #16176

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: duplicate prefix in staking keys #16176

merged 1 commit into from
May 16, 2023

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from a team as a code owner May 16, 2023 10:49
@github-actions
Copy link
Contributor

@atheeshp your pull request is missing a changelog!

@julienrbrt
Copy link
Member

The bot mentions a changelog but that's a false positive as this never been released.

@atheeshp
Copy link
Contributor Author

The bot mentions a changelog but that's a false positive as this never been released.

Yes

@atheeshp atheeshp enabled auto-merge May 16, 2023 10:57
@atheeshp atheeshp added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 76f0d10 May 16, 2023
@atheeshp atheeshp deleted the ap/fix-key branch May 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants