-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make StartCmd more customizable #16209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
kocubinski and
alexanderbez
and removed request for
a team
May 18, 2023 09:04
yihuang
commented
May 18, 2023
julienrbrt
reviewed
May 18, 2023
ValarDragon
reviewed
May 18, 2023
yihuang
commented
May 18, 2023
alexanderbez
approved these changes
May 18, 2023
yihuang
added
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
labels
May 19, 2023
julienrbrt
approved these changes
May 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2023
(cherry picked from commit de75e56) # Conflicts: # CHANGELOG.md # server/start.go
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2023
(cherry picked from commit de75e56) # Conflicts: # CHANGELOG.md # server/start.go
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we've been using a custom
StartCmd
in ethermint for a long time, if the builtin one is more customizable, we can be freed from manually syncing with upstream updates.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change