Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make StartCmd more customizable #16209

Merged
merged 6 commits into from
May 19, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 18, 2023

Description

we've been using a custom StartCmd in ethermint for a long time, if the builtin one is more customizable, we can be freed from manually syncing with upstream updates.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang requested a review from a team as a code owner May 18, 2023 09:04
@github-prbot github-prbot requested review from a team, kocubinski and alexanderbez and removed request for a team May 18, 2023 09:04
CHANGELOG.md Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
@yihuang yihuang added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels May 19, 2023
@julienrbrt julienrbrt added this pull request to the merge queue May 19, 2023
Merged via the queue into cosmos:main with commit de75e56 May 19, 2023
mergify bot pushed a commit that referenced this pull request May 19, 2023
(cherry picked from commit de75e56)

# Conflicts:
#	CHANGELOG.md
#	server/start.go
mergify bot pushed a commit that referenced this pull request May 19, 2023
(cherry picked from commit de75e56)

# Conflicts:
#	CHANGELOG.md
#	server/start.go
@yihuang yihuang deleted the db-opener branch May 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants