refactor(distribution)!: use collections for params state #16211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
JeancarloBarrios and
atheeshp
and removed request for
a team
tac0turtle
approved these changes
May 18, 2023
x/distribution/keeper/params.go
Outdated
| bz, err := store.Get(types.ParamsKey) | ||
| if bz == nil || err != nil { | ||
| func (k Keeper) GetParams(ctx context.Context) (types.Params, error) { | ||
| params, err := k.Params.Get(ctx) |
There was a problem hiding this comment.
I think this function can be shorthanded to just return return k.Params.Get
julienrbrt
approved these changes
May 19, 2023
CHANGELOG.md
Outdated
| @@ -211,6 +211,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * `simulation.NewOperationMsg` is now 2-arity instead of 3-arity with the obsolete argument `codec.ProtoCodec` removed. | |||
| * The field `OperationMsg.Msg` is now of type `[]byte` instead of `json.RawMessage`. | |||
|
|
|||
| * (x/distribution)[#16211](https://github.com/cosmos/cosmos-sdk/pull/16211) Use collections for params state management. | |||
There was a problem hiding this comment.
nit space between the package and the PR and no need the space L213.
julienrbrt
reviewed
May 19, 2023
samricotta
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16210
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change