-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changelog & upgrading documentation for ABCI++ #16315
Conversation
Slightly unrelated but posting this here, so we can add it in the changelog as well: #16043 (comment) (and then I can close a tab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits (the link and the title). We will still need docs for updating the flow.
We still require docs to update the baseapp core concepts and describe finalize block, verify vote extensions, etc..
It will be great as well to add a disclaimer here: https://docs.cosmos.network/v0.50/building-modules/beginblock-endblock about what means BeginBlock and EndBlock now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I guess the other updates I suggested could be done in another issue as part of QA: #16315 (review)
i will pick this up |
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 9769e24)
… (#16482) Co-authored-by: Marko <marbar3778@yahoo.com>
Description
Closes: #12272
this adds a changelog for changes from integrating comet 0.38
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change