feat: custom get signers #16340
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package tx | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "cosmossdk.io/depinject" | ||
| "cosmossdk.io/log" | ||
| "cosmossdk.io/x/tx/signing" | ||
| "github.com/stretchr/testify/require" | ||
| "google.golang.org/protobuf/proto" | ||
|
|
||
| codectypes "github.com/cosmos/cosmos-sdk/codec/types" | ||
| "github.com/cosmos/cosmos-sdk/tests/integration/tx/internal/pulsar/testpb" | ||
| "github.com/cosmos/cosmos-sdk/testutil/configurator" | ||
| simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims" | ||
| ) | ||
|
|
||
| func ProvideCustomGetSigners() signing.CustomGetSigner { | ||
|
There was a problem hiding this comment. nice, it will be useful if this could be displayed in the docs ref: #16294 |
||
| return signing.CustomGetSigner{ | ||
| MsgType: proto.MessageName(&testpb.TestRepeatedFields{}), | ||
| Fn: func(msg proto.Message) ([][]byte, error) { | ||
| testMsg := msg.(*testpb.TestRepeatedFields) | ||
| // arbitrary logic | ||
| signer := testMsg.NullableDontOmitempty[1].Value | ||
| return [][]byte{[]byte(signer)}, nil | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func TestDefineCustomGetSigners(t *testing.T) { | ||
| var interfaceRegistry codectypes.InterfaceRegistry | ||
| _, err := simtestutil.SetupAtGenesis( | ||
| depinject.Configs( | ||
| configurator.NewAppConfig( | ||
| configurator.ParamsModule(), | ||
| configurator.AuthModule(), | ||
| configurator.StakingModule(), | ||
| configurator.BankModule(), | ||
| configurator.ConsensusModule(), | ||
| ), | ||
| depinject.Supply(log.NewNopLogger()), | ||
| depinject.Provide(ProvideCustomGetSigners), | ||
| ), | ||
| &interfaceRegistry, | ||
| ) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, interfaceRegistry) | ||
|
|
||
| msg := &testpb.TestRepeatedFields{ | ||
| NullableDontOmitempty: []*testpb.Streng{ | ||
| {Value: "foo"}, | ||
| {Value: "bar"}, | ||
| }, | ||
| } | ||
| signers, err := interfaceRegistry.SigningContext().GetSigners(msg) | ||
| require.NoError(t, err) | ||
| require.Equal(t, [][]byte{[]byte("bar")}, signers) | ||
|
|
||
| // Reset and provider no CustomGetSigners. Consequently, validation will fail and depinject will return an error | ||
| _, err = simtestutil.SetupAtGenesis( | ||
| depinject.Configs( | ||
| configurator.NewAppConfig( | ||
| configurator.ParamsModule(), | ||
| configurator.AuthModule(), | ||
| configurator.StakingModule(), | ||
| configurator.BankModule(), | ||
| configurator.ConsensusModule(), | ||
| ), | ||
| depinject.Supply(log.NewNopLogger()), | ||
| ), | ||
| &interfaceRegistry, | ||
| ) | ||
| require.ErrorContains(t, err, "use DefineCustomGetSigners") | ||
| } | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still we just require a signing context to be passed in? Seems like signing options already takes proto files already so there's some redundancy here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could but
signing.Optionspermits an nilProtoFileResolverwhile interface registry does not. What do you think we ought to do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just enforce the check at the interface registry level, or allow a nil resolver and default to hybrid resolver. But duplicated fields in both options structures might be confusing right?