Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change prepare and process proposal to be NoOps by default #16407

Merged
merged 4 commits into from
Jun 2, 2023
Merged

chore: change prepare and process proposal to be NoOps by default #16407

merged 4 commits into from
Jun 2, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review June 2, 2023 11:19
@tac0turtle tac0turtle requested a review from a team as a code owner June 2, 2023 11:19
@tac0turtle tac0turtle added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jun 2, 2023
@github-prbot github-prbot requested review from a team, aaronc and testinginprod and removed request for a team June 2, 2023 11:19
@tac0turtle tac0turtle changed the title chore: change prepare and process proposal to be NoOps chore: change prepare and process proposal to be NoOps by default Jun 2, 2023
sergio-mena
sergio-mena reviewed Jun 2, 2023
View reviewed changes
baseapp/abci_utils.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jun 2, 2023
View reviewed changes
baseapp/baseapp.go Outdated Show resolved Hide resolved
sergio-mena
sergio-mena approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

tac0turtle and others added 2 commits June 2, 2023 09:02
@tac0turtle
minor revert
a6e42e6
@tac0turtle @sergio-mena
Update baseapp/abci_utils.go
ceb4958 
Co-authored-by: Sergio Mena <sergio@informal.systems>
alexanderbez
alexanderbez approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it would be super helpful if PRs included at least a short description of the issue/context and what the PR does :)

Given that we check for no-op mempool in PrepareProposal, it makes sense to do the same for ProcessProposal 👍

docs/docs/building-apps/02-app-mempool.md Outdated Show resolved Hide resolved
docs/docs/building-apps/02-app-mempool.md Outdated Show resolved Hide resolved
baseapp/abci_utils.go Outdated Show resolved Hide resolved
@tac0turtle @alexanderbez
Apply suggestions from code review
8f303c6 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@tac0turtle tac0turtle enabled auto-merge June 2, 2023 13:44
@tac0turtle tac0turtle added this pull request to the merge queue Jun 2, 2023
Merged via the queue into main with commit efdc955 Jun 2, 2023
@tac0turtle tac0turtle deleted the marko/process_proposal_fix branch June 2, 2023 14:49
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
@tac0turtle @mergify
chore: change prepare and process proposal to be NoOps by default (#1…
2fca9ea 
…6407)

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit efdc955)

# Conflicts:
#	baseapp/abci_utils.go
@mergify mergify bot mentioned this pull request Jun 2, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Jun 2, 2023
@mergify
chore: change prepare and process proposal to be NoOps by default (ba…
ba2f1be 
…ckport #16407) (#16410)
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
@mergify @roy-dydx
chore: change prepare and process proposal to be NoOps by default (ba…
d30d57a 
…ckport cosmos#16407) (cosmos#16410)
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
@mergify @kakysha
chore: change prepare and process proposal to be NoOps by default (ba…
7c5f95c 
…ckport cosmos#16407) (cosmos#16410)
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-mena sergio-mena sergio-mena approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @alexanderbez @sergio-mena @julienrbrt