Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean-up all replaces and add tagging process #16528

Merged
merged 13 commits into from
Jun 14, 2023
Merged

chore: clean-up all replaces and add tagging process #16528

merged 13 commits into from
Jun 14, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 13, 2023 •
edited
Loading

Description

  • Clean-up replaces from all modules depending on the SDK
  • Describe process of tagging modules on the SDK.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade labels Jun 13, 2023
Base automatically changed from julien/cleanup-deps to main June 13, 2023 13:53
@julienrbrt julienrbrt marked this pull request as ready for review June 13, 2023 14:33
@julienrbrt julienrbrt requested a review from a team as a code owner June 13, 2023 14:33
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 13, 2023
julienrbrt
julienrbrt commented Jun 13, 2023
View reviewed changes
RELEASE_PROCESS.md
@@ -215,3 +215,28 @@ Currently residing Stable Release Managers:

* @tac0turtle - Marko Baricevic
* @julienrbrt - Julien Robert

## Cosmos SDK Modules
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tac0turtle

tac0turtle
tac0turtle approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the addition to the release process

@github-actions github-actions bot removed C:Hubl Tool: Hubl C:Cosmovisor Issues and PR related to Cosmovisor labels Jun 14, 2023
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Jun 14, 2023
@julienrbrt julienrbrt disabled auto-merge June 14, 2023 11:04
@julienrbrt julienrbrt added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit 7a55c93 Jun 14, 2023
@julienrbrt julienrbrt deleted the julien/cleanup-deps-2 branch June 14, 2023 11:24
mergify bot pushed a commit that referenced this pull request Jun 14, 2023
@julienrbrt @mergify
chore: clean-up all replaces and add tagging process (#16528)
8a8daee 
(cherry picked from commit 7a55c93)

# Conflicts:
#	go.sum
#	simapp/go.sum
#	tests/go.sum
#	tools/confix/go.sum
#	tools/cosmovisor/go.mod
#	tools/cosmovisor/go.sum
#	x/evidence/go.sum
#	x/nft/go.sum
#	x/upgrade/go.sum
@mergify mergify bot mentioned this pull request Jun 14, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 14, 2023
@mergify @julienrbrt
chore: clean-up all replaces and add tagging process (backport #16528) (
5c3139b 
#16539)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt mentioned this pull request Jun 14, 2023
Merged
19 tasks
tac0turtle
tac0turtle reviewed Oct 21, 2023
View reviewed changes
simapp/go.mod
github.com/cometbft/cometbft v0.38.0-rc1
github.com/cosmos/cosmos-db v1.0.0
// this version is not used as it is always replaced by the latest Cosmos SDK version
github.com/cosmos/cosmos-sdk v0.50.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was 0.51 set here? getting an error when trying to create new go mods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is always replaced. It allows simapp on main to properly display the next sdk version (simapp version --long)

So it does not matter. When you have new go mod, you need to use latest main or have it replace the sdk.

@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @alexanderbez @tac0turtle