Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(feegrant): collection migration #16535

Merged
merged 27 commits into from
Jul 28, 2023
Merged

refactor(feegrant): collection migration #16535

merged 27 commits into from
Jul 28, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 14, 2023 •
edited
Loading

Description

Closes: #16371, #16369
ref: #14300

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review July 25, 2023 16:19
@atheeshp atheeshp requested a review from a team as a code owner July 25, 2023 16:19
@tac0turtle tac0turtle changed the title chore(wip): collection migration of feegrant chore: collection migration of feegrant Jul 25, 2023
@facundomedica facundomedica self-assigned this Jul 26, 2023
julienrbrt
julienrbrt reviewed Jul 26, 2023
View reviewed changes
collections/triple.go Outdated
@@ -273,6 +273,15 @@ func (t tripleKeyCodec[K1, K2, K3]) SizeNonTerminal(key Triple[K1, K2, K3]) int
return size
}

// PrefixUntilTripleRange defines a collection query which ranges until the provided Pair prefix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to split this in a separate PR, so that you can use a pseudo version from main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@julienrbrt julienrbrt changed the title chore: collection migration of feegrant refactor(feegrant): collection migration Jul 26, 2023
@atheeshp atheeshp requested a review from julienrbrt July 27, 2023 09:55
@atheeshp atheeshp requested a review from julienrbrt July 28, 2023 07:13
julienrbrt
julienrbrt approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

CHANGELOG.md Outdated Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt linked an issue Jul 28, 2023 that may be closed by this pull request
refactor(feegrant): move FeeAllowanceQueue to collections #16369
Closed
@atheeshp atheeshp enabled auto-merge July 28, 2023 15:12
@atheeshp atheeshp added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit e51e74a Jul 28, 2023
48 checks passed
@atheeshp atheeshp deleted the ap/feegrant-collection branch July 28, 2023 15:26
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees

@facundomedica facundomedica

Labels
C:x/feegrant
Projects
None yet
Milestone
No milestone
4 participants
@atheeshp @julienrbrt @testinginprod @facundomedica