Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mint): add autocli config for mint #16640

Merged
merged 2 commits into from
Jun 22, 2023
Merged

feat(mint): add autocli config for mint #16640

merged 2 commits into from
Jun 22, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

Description

ref: #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner June 22, 2023 00:01
@github-actions
Copy link
Contributor

@JeancarloBarrios your pull request is missing a changelog!

@JeancarloBarrios JeancarloBarrios mentioned this pull request Jun 22, 2023
Closed
17 tasks
@JeancarloBarrios JeancarloBarrios changed the title feat(mint): add autocli config to int feat(mint): add autocli config for mint Jun 22, 2023
@JeancarloBarrios JeancarloBarrios marked this pull request as draft June 22, 2023 00:21
@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review June 22, 2023 00:58
@JeancarloBarrios JeancarloBarrios added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 854978f Jun 22, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/add-autocli-config-mint branch June 22, 2023 05:07
@julienrbrt julienrbrt mentioned this pull request Jun 22, 2023
Closed
19 tasks
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 22, 2023
@JeancarloBarrios @mergify
feat(mint): add autocli config for mint (#16640)
c0b597e 
(cherry picked from commit 854978f)

# Conflicts:
#	x/mint/module.go
@mergify mergify bot mentioned this pull request Jun 22, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 22, 2023
@mergify @JeancarloBarrios @julienrbrt
feat(mint): add autocli config for mint (backport #16640) (#16648)
7c1c2c9 
Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

Assignees
No one assigned
Labels
C:CLI C:x/mint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeancarloBarrios @julienrbrt @atheeshp