Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: audit x/mint #16702

Merged
merged 2 commits into from
Jun 27, 2023
Merged

chore: audit x/mint #16702

merged 2 commits into from
Jun 27, 2023

Conversation

tac0turtle
Copy link
Member

Description

no core logic changes incurred on mint from 0.47 to 0.50. The only change is adoption of collections and KVStoreservice.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title chore: mint read through chore: audit x/mint Jun 27, 2023
@tac0turtle tac0turtle marked this pull request as ready for review June 27, 2023 12:02
@tac0turtle tac0turtle requested a review from a team as a code owner June 27, 2023 12:02
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 27, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit e8eb90d Jun 27, 2023
@tac0turtle tac0turtle deleted the marko/mint_audit_ branch June 27, 2023 12:37
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
(cherry picked from commit e8eb90d)
julienrbrt pushed a commit that referenced this pull request Jun 27, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/mint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants