-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove types/math
aliases
#16798
Conversation
proto/cosmos/base/v1beta1/coin.proto
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be tagging a new api module after this PR.
EDIT: not needed yet, let's wait instead.
CHANGELOG.md
Outdated
@@ -243,8 +243,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
* `MsgSendExec` test helper function now takes a address.Codec | |||
* (x/genutil) [#15567](https://github.com/cosmos/cosmos-sdk/pull/15567) `CollectGenTxsCmd` & `GenTxCmd` takes a address.Codec to be able to decode addresses | |||
* (x/genutil) [#15999](https://github.com/cosmos/cosmos-sdk/pull/15999) Genutil now takes the `GenesisTxHanlder` interface instead of deliverTx. The interface is implemented on baseapp | |||
* (types/math) [#16040](https://github.com/cosmos/cosmos-sdk/pull/16040) Remove unused aliases in math.go | |||
* (x/gov) [#16106](https://github.com/cosmos/cosmos-sdk/pull/16106) Remove gRPC query methods from Keeper | |||
* (types/math) [#16040](https://github.com/cosmos/cosmos-sdk/pull/16040) Remove aliases in `types/math.go`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog already exists, so I do not think we need another changelog for the final release however, for the alpha it may still be useful to have a changelog. We can collapse them at the final release.
NewInt = sdkmath.NewInt | ||
ZeroInt = sdkmath.ZeroInt | ||
) | ||
|
||
func (ip IntProto) String() string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove these if this is ACK: #15949
But this is out of scope of #14405 / #14405 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do this in a folllow up
(cherry picked from commit 8c72f66) # Conflicts: # CHANGELOG.md # x/auth/migrations/v2/store.go # x/tx/signing/aminojson/internal/buf.lock
Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
Closes: #14405
ref #16475 (comment)
protocgen.sh
to re-generate all tests protos (one was missing)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change