Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bank): make DenomAddressIndex less strict with respect to index values. (backport #16841) #16853

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 6, 2023

This is an automatic backport of pull request #16841 done by Mergify.
Cherry-pick of acce343 has failed:

On branch mergify/bp/release/v0.50.x/pr-16841
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit acce343a1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   x/bank/keeper/collections_test.go
	modified:   x/bank/types/keys.go
	modified:   x/bank/types/keys_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   x/bank/keeper/view.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

… values. (#16841)

Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit acce343)

# Conflicts:
#	CHANGELOG.md
#	x/bank/keeper/view.go
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can be merged after this: #16854

@julienrbrt julienrbrt merged commit c919775 into release/v0.50.x Jul 6, 2023
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.50.x/pr-16841 branch July 6, 2023 11:59
nicopernas added a commit to polymerdao/cosmos-sdk that referenced this pull request Aug 1, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants