Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gov audit (secondary reviewer) #16870

Merged
merged 2 commits into from
Jul 7, 2023
Merged

chore: gov audit (secondary reviewer) #16870

merged 2 commits into from
Jul 7, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 7, 2023

Description

The findings & audit changes of Likhita is looking good,
cancel proposal is being introduced and reviewed it thoroughly.
Except that didn't find any critical things.

Closes: #16781


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from a team as a code owner July 7, 2023 07:53
@atheeshp atheeshp requested review from likhita-809 and removed request for facundomedica and samricotta July 7, 2023 07:53
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 7, 2023
@atheeshp atheeshp enabled auto-merge July 7, 2023 08:04
@atheeshp atheeshp added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit a897642 Jul 7, 2023
@atheeshp atheeshp deleted the ap/gov-2nd-review branch July 7, 2023 11:38
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
julienrbrt pushed a commit that referenced this pull request Jul 7, 2023
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit x/gov v0.47...v0.50
2 participants