-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: simplify AppModuleBasic
interface for CLI
#16890
Conversation
if cmd := b.GetTxCmd(); cmd != nil { | ||
rootTxCmd.AddCommand(cmd) | ||
if mod, ok := b.(interface { | ||
GetTxCmd() *cobra.Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, this replicates the behavior from the Core API Adapter:
cosmos-sdk/types/module/core_module.go
Lines 137 to 145 in adb03ec
func (c coreAppModuleBasicAdaptor) GetQueryCmd() *cobra.Command { | |
if mod, ok := c.module.(interface { | |
GetQueryCmd() *cobra.Command | |
}); ok { | |
return mod.GetQueryCmd() | |
} | |
return nil | |
} |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
x/mint/module.go
Outdated
// GetTxCmd returns no root tx command for the mint module. | ||
func (AppModuleBasic) GetTxCmd() *cobra.Command { return nil } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove as well?
(cherry picked from commit f3e4697) # Conflicts: # CHANGELOG.md # x/evidence/go.mod # x/evidence/go.sum # x/nft/go.mod # x/nft/go.sum
…16904) Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
ref: #16754 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change