Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/circuit): msg_url is skipped when publishing events #17105

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

ysv
Copy link
Contributor

@ysv ysv commented Jul 24, 2023

Description

Closes: #17087


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ysv ysv requested a review from a team as a code owner July 24, 2023 10:21
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for submitting this pr, nice find as well

@ysv ysv force-pushed the fix/circuit-msg-url-missing branch from 5b18bfb to 04dcbf8 Compare July 24, 2023 10:54
CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 24, 2023
@julienrbrt
Copy link
Member

Could you fix the linting issues? (by running f.e make lint-fix)

@ysv
Copy link
Contributor Author

ysv commented Jul 24, 2023

Could you fix the linting issues? (by running f.e make lint-fix)

done

@julienrbrt julienrbrt added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cosmos:main with commit 9c6a225 Jul 24, 2023
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
julienrbrt pushed a commit that referenced this pull request Jul 24, 2023
…17105) (#17108)

Co-authored-by: Yaroslav Savchuk <savchukyarpolk@gmail.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/circuit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In x/circuit module events msg_url attribute is not set in case of single msgType trip/reset
3 participants