Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): Migrate Validators to use Collections #17123

Merged
merged 42 commits into from
Aug 28, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16377


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 force-pushed the likhita/validators-coll branch from a6ff14c to 37d1e02 Compare August 8, 2023 06:53
@github-actions github-actions bot removed C:x/slashing C:x/distribution distribution module related labels Aug 8, 2023
x/staking/keeper/validator.go Fixed Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two questions otherwise looks good

@likhita-809 likhita-809 requested a review from tac0turtle August 23, 2023 11:11
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! one doubt.

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm

x/staking/keeper/keeper.go Outdated Show resolved Hide resolved
x/staking/keeper/unbonding.go Outdated Show resolved Hide resolved
@likhita-809 likhita-809 requested a review from atheeshp August 28, 2023 12:13
@tac0turtle tac0turtle added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 70b3e85 Aug 28, 2023
@tac0turtle tac0turtle deleted the likhita/validators-coll branch August 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move Validators to use collections
7 participants